TomIO

> Looks fine otherwise from a quick look. > > However, note that debian does not use `LICENSE` as file names, it uses (a single) `copyright`, so would be better...

> For checking if license file was added. > > ```shell > license_files="$(find "$TERMUX_PREFIX/share/doc/$TERMUX_PKG_NAME" -maxdepth 1 -type f -name "LICENSE*")" > if [ -z "$license_files" ]; then > # error...

> However, I do suggest that we use `copyright` and `copyright.` format right now as that is the standard which wouldn't be hard to follow and would provide consistency with...

> Well, if you wanna rebuild all 2000+ packages, who am I to say no, have fun with failed builds and missing source urls :p CI's been flakey lately anyway....

Alright, that's: - `copyright.${counter}` as license name - adding `copyright` to the search list - turning the license filepath into a variable - accursed hashmap magic If you still want...

> Based on above, best use following. It will not match broken symlinks to license files, assuming that's what we want. > > ```shell > license_files="$(find -L "$TERMUX_PREFIX/share/doc/$TERMUX_PKG_NAME" -maxdepth 1...

Going with ```bash local license_files license_files="$(find -L "$TERMUX_PREFIX/share/doc/$TERMUX_PKG_NAME" -maxdepth 1 \( -type f -o -type l \) -name "copyright*")" [[ -n "$license_files" ]] || { termux_error_exit "No LICENSE file was...

> How dare you! I think the `||` more clearly identifies this as an exception path.

This would only catch all license files missing. Am I correct in that assumption? Just wondering if we wanna do something about individual missing licenses. We can probably co-opt the...

I think I'll just be satisfied with `cp`'s error message if it can't find the license file in the source repo. And `ln` is only invoked for "known generic licenses",...