vMenu icon indicating copy to clipboard operation
vMenu copied to clipboard

Add timer to update Online Players list when on the list

Open Beachman4 opened this issue 4 years ago • 3 comments
trafficstars

Hey there, I noticed since the online player list currently updates when you open it, when on the player list for a while, it obviously doesn't update. So when selecting a player that has disconnected and you go to spectate the disconnected player, it spectates you instead.

This PR makes it so when you open the list, it will automatically update the list every 10 seconds. If you back out of the Online Players menu, it will cancel the timer. If the player you have selected has disconnected, it will back you out and let you know that they disconnected. Not a huge fan of while (true)s, so if needed I can change it to recursion instead.

I can make this a togglable feature if you feel that it should be.

Beachman4 avatar Feb 22 '21 03:02 Beachman4

Need to fix a few things before I reopen

Beachman4 avatar Feb 22 '21 03:02 Beachman4

Need to fix a few things before I reopen

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft :)

lze3 avatar Feb 22 '21 04:02 lze3

Need to fix a few things before I reopen

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft :)

Thanks! Still not used to draft prs haha

Beachman4 avatar Feb 22 '21 04:02 Beachman4

Yeah for some reason this pr has commits that are not mine. I must have mistakenly started this branch from another

Beachman4 avatar Mar 04 '23 17:03 Beachman4

If it's too much work to fix this, you could always create a new branch from the development branch, and copy your changes over that you actually want and then just create a new PR.

TomGrobbe avatar Mar 04 '23 17:03 TomGrobbe

Any updates on this?

christopher-nzcs avatar Jul 16 '23 09:07 christopher-nzcs

If you still want this to be merged, please update the code. There have been many updates and code changes that have made conflicts.

christopher-nzcs avatar Feb 08 '24 13:02 christopher-nzcs