dropwizard-websocket-jsr356-bundle icon indicating copy to clipboard operation
dropwizard-websocket-jsr356-bundle copied to clipboard

Support for Dropwizard 3.x

Open BastienDurel opened this issue 2 years ago • 8 comments

Hello.

It would be nice if Dropwizard 3.x could be added. Only a few import/interface renames are needed. (dropwizard-websocket-jee7-bundle cannot be used as jetty version changed (and some base DW classes changed package))

I've done that on https://github.com/BastienDurel/dropwizard-websocket-jsr356-bundle/tree/dropwizard_3 (with only a version chnge, don't know if a new artifact name would be better)

BastienDurel avatar May 23 '23 10:05 BastienDurel

I could introduce a new 3.x branch for that to work! However; I'd like to motivate people to jump on the newer 4.x. If this 3.x is requested by a few more people (by commenting here), then I'll do it. 👍

TomCools avatar May 24 '23 19:05 TomCools

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

YSavitski avatar Jun 01 '23 15:06 YSavitski

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

TomCools avatar Jun 01 '23 15:06 TomCools

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version Thx in advacne image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

Hi @TomCools Thank you for hint with link !

YSavitski avatar Jun 01 '23 20:06 YSavitski

This would be awesome to have to make upgrading Dropwizard easier, as I could stage it from 2->3, then 3->4. In someways it would be better to go just from 2->4, but I'm trying simplify the number of libraries to upgrade.

spags-lacework avatar Aug 07 '24 00:08 spags-lacework

Hey @TomCools I'm fully with @spags-lacework . It would be great to have support of intermediate version 3.x. We're going to upgrade our projects and may see that doing upgrade from 2.1.x to 4.x within the one step is too complex and might be dangerous

YSavitski avatar Sep 20 '24 07:09 YSavitski

Hey @TomCools would it be possible to review my changes https://github.com/TomCools/dropwizard-websocket-jsr356-bundle/pull/19 ? Many thanks in advance

YSavitski avatar Sep 23 '24 06:09 YSavitski