Tom Augspurger
Tom Augspurger
@rjzamora do you have any concerns with this? This adds a bit more friction to putting something in `state` (you have to declare it in `CachingVisitorState`), but I think the...
I felt that awkwardness too. It's identical to what we have today, it's just that declaring the types makes it obvious that we're putting all kinds of things in there....
I pushed some changes that seem to do what we want. It's a bit complicated... but I think worth it. Now we have a `LowerIRTransformer` type: ``` LowerIRTransformer: TypeAlias =...
I'm not familiar with the current drop_duplicates implementation. @Tunahanyrd let us know if you're interested in taking this on and need any tips to get started.
What's the behavior of scikit-learn here? We should match that, unless there's some reason not to. One thing to note: we can't check the length of the DataFrame / array...
Sure, thank.
Oh, this is maybe just a row order issue. It passes with `check_row_order=False`. We need to confirm whether that's expected (and if so document that behavior).
I missed one set of errors previously that might be a distinct issue. https://github.com/rapidsai/cudf/blob/4466e55ba153ef13fa2327c3f0e00447aeb09b97/python/cudf_polars/tests/test_join.py#L91-L97 is a set of tests that does a join followed by a `slice`. That failing without...
Thanks for the PR @aryansri05. Don't worry about the labels, we can add those. @mroeschke would you have a chance to review this? Do you have a sense for whether...