NoteStream icon indicating copy to clipboard operation
NoteStream copied to clipboard

Make stream creation atomic

Open TomAFrench opened this issue 5 years ago • 1 comments

This PR consolidates the two transactions to create a stream (sending ZkAsset to contract and initialising stream) into one.

Currently blocked as the AZTEC SDK doesn't support signing an approval for the contract to submit the JoinSplit proof. The approval could be generated outside the sdk could be a worrying change to the standard flow for users.

closes #25

Tasks before merging:

  • [x] test failure conditions in StreamUtilities.sol
  • [ ] test success outcomes of StreamUtilities.sol functions
  • [ ] update frontend to call new sdk method to get signed proof
  • [ ] deploy new contract to rinkeby to close #41

TomAFrench avatar Apr 09 '20 14:04 TomAFrench

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

vercel[bot] avatar Apr 09 '20 14:04 vercel[bot]