toloka-kit icon indicating copy to clipboard operation
toloka-kit copied to clipboard

Update learn_the_basics.ipynb

Open zloid89 opened this issue 2 years ago • 2 comments

Minor error fix in learn_the_basics

Renaming column 'ASSIGNMENT:worker_id': 'performer' in answers_df will cause an error on the next step.

Description

String 669. Renaming column 'ASSIGNMENT:worker_id': 'performer' in answers_df will cause an error on the next step - "Run majority vote aggregation". It could me solved by renaming the column to "worker".

Connected issues (if any)

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation and examples improvement (changes affected documentation and/or examples)

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

zloid89 avatar Jul 05 '22 14:07 zloid89

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zloid89 Hello, could you rebase to master, please, to make tests pass

Pocoder avatar Jul 06 '22 14:07 Pocoder

Fixed in https://github.com/Toloka/toloka-kit/pull/83

DrhF avatar Oct 24 '22 09:10 DrhF