smart-contracts

smart-contracts copied to clipboard

Eliminate throw()

1

throw is deprecated; move to assert() and revert() in all contracts

miohtama

Currently `build/expanded` contract output is written by `deploy-contracts` only if the contract is verified on EtherScan. This should be written regardless.

miohtama

Fix typing contracts, tests, documentation

miohtama

Bumps [eth-account](https://github.com/ethereum/eth-account) from 0.3.0 to 0.5.9. Changelog Sourced from eth-account's changelog. eth-account v0.5.9 (2022-08-04) Bugfixes - fix DoS-able regex pattern (`[#178](https://github.com/ethereum/eth-account/issues/178) <https://github.com/ethereum/eth-account/issues/178>`__) Miscellaneous changes [#183](https://github.com/ethereum/eth-account/issues/183) <https://github.com/ethereum/eth-account/issues/183>, [#184](https://github.com/ethereum/eth-account/issues/184) <https://github.com/ethereum/eth-account/issues/184> eth-account v0.5.8...

dependabot[bot]

Pay-direct-to-smart-contract risks using fallback function

13

As an investor, I'd like to buy tokens using contact address which is fallback function. I see this pattern is used quite extensively in your contracts with 1 caution: all...

rstormsf

check condition first, then change state

1

https://github.com/TokenMarketNet/ico/blob/master/contracts/CrowdsaleBase.sol#L250 I believe that the check that if the contract is finalizeAgent should be done first and only then to modify state variable ``` function setFinalizeAgent(FinalizeAgent addr) onlyOwner { require(addr.isFinalizeAgent());...

rstormsf

https://github.com/TokenMarketNet/ico/blob/master/contracts/PricingStrategy.sol the contract is being used as an interface. In Solidity, there is keyword: `interface` which must be used instead of `contract` Also, it shouldn't have any state variables and...

rstormsf

https://github.com/TokenMarketNet/ico/blob/9f114b1cad7312f95e937cd1e855af35b9d97214/contracts/CrowdsaleBase.sol#L213 https://github.com/TokenMarketNet/ico/blob/9f114b1cad7312f95e937cd1e855af35b9d97214/contracts/CrowdsaleBase.sol#L332 https://github.com/ethereum/solidity/issues/610 since `transfer` already does throw an error on failure, I think it could be cleaner approach instead. Proposed change to ``` multisigWallet.transfer(weiAmount) ```

rstormsf

Bumps [certifi](https://github.com/certifi/python-certifi) from 2017.7.27.1 to 2022.12.7. Commits 9e9e840 2022.12.07 b81bdb2 2022.09.24 939a28f 2022.09.14 aca828a 2022.06.15.2 de0eae1 Only use importlib.resources's new files() / Traversable API on Python ≥3.11 ... b8eb5e9 2022.06.15.1...

dependabot[bot]

robbynjanaealways