Adrien Foulon

Results 434 comments of Adrien Foulon

Okay I completely rechanged the approach, I got everything working perfectly finally, schema is clean and a bit less memory hungry than before I also tested old revisions and switching...

Good to go now repeaters are only stored like ``` parts blocks-parts-1|lessons blocks-lessons-1|content ``` Instead of the original approach of ``` parts parts|blocks-parts-1|lessons parts|blocks-parts-1|lessons|blocks-lessons-1|content ``` Or the current not working...

I think I'm pretty much done on the best way to approach this by causing the least amount of breaking change Now the schema hasn't even changed except for the...

Is the disableLocaleSlug even needed before? This seems to be done already in updateOrNewSlug and I'm sure it's interfering with getOldSlug->active

That seems to be the source of the issue ``` private function seedDefaultRoles() { // Default roles and their permissions $roles = [ 'Owner' => Permission::available(Permission::SCOPE_GLOBAL), 'Administrator' => array_diff(Permission::available(Permission::SCOPE_GLOBAL), ["edit-user-roles",...

> or we should show the list of roles with a position higher or equal to that of the current user's role That's already the case in the logic if...

> you're supposed to be logged in as superadmin locally by default Yes, but then you can create another user, give it the administrator role and login with it and...

> Don't you agree that the ability to create new user roles needs to be gated more than creating/editing content? The ability to create/edit roles yes absolutely, but the ability...

Ah yes I see what the sortBy was for then, I'll make sure to restore it if a block list is given The issue is now the rules have gotten...

I didn't yet figure out what's causing the js error in the tests as when using the PR anywhere else there is no issue, I can't run dusk on WSL...