Adrien Foulon

Results 434 comments of Adrien Foulon

No problem with me, I'm also very busy and didn't have time to review this to make a PR for v4 and v5, though I do believe there were a...

Here I took the code from the old PR and adapted it for v4 ```php /** * @deprecated Use {@see getChangedColumns()} instead. * * @return list */ public function getModifiedColumns():...

My PR does not remove the rename detection even if an explicit renaming has been provided (maybe it should?) but if a column is explicitly renamed then those 2 particular...

Since the detection is made from dropped columns and added columns of the same type, I'm thinking of an alternative, which would be to tag dropped columns, when doing `dropColumn`,...

You could still iterate over the tables and columns in the old schema to set the flag Or an in between, we add a configuration in the SchemaConfig of Table...

I guess that's very much a question of taste Personally I like it, in forms it attracts the user's attention to what is in error, sometimes just a red text...

The author and maintainer of the lib is @rikschennink not the author of the closed PR

Same issue here, a free number input would be great to fine tune

I just tried from a simple barebone snippet ```php

Yes just add a `@unlink('test.zip')` if you need but this is not the issue I managed to reproduce it with a path as well ```php $archive->addFile('absolute_path_to_an_existing_file.jpg', '\\foo\\test.jpg'); ``` This creates...