jQuery-Mobile-Subpage-Widget icon indicating copy to clipboard operation
jQuery-Mobile-Subpage-Widget copied to clipboard

Please update the Subpage Widget to use the latest JQM and provide a working sample other than MVC

Open ppetree opened this issue 6 years ago • 4 comments

If anyone else stumbles on this, it doesn't work, at least not with JQM 1.4.5.

While the page data-role=subpage does get converted to data-role=page and a few classes get added, $.mobile.changePage() can't find the page.

Also, unless you're an MVC coder (I'll bet 90% of the JQM developers aren't), don't bother with the examples.

ppetree avatar Jun 06 '18 15:06 ppetree

@ppetree This repo is 4 to 5 years old and is no longer being worked on and will not be updated by the original author (me). The beauty of GitHub and open source is that anyone can fork the source, make suitable changes that meet their needs and pass on the goodness to the rest of the community in the form of a PR.

The Subpage Widget is relatively simple and met my needs for many years in production environments (also by many others). Please feel free to fork the code and issue a PR or take over the project.

ToddThomson avatar Jun 06 '18 16:06 ToddThomson

Your solution looked genius and I was excited to find it and really couldn't imagine it not working based on the dates but alas... Sometimes we run across a piece of old code that still works and works well... other times, not so much.

I made my comment so that others coming behind me who have the same problem don't exhaust a few hours trying to make something work that doesn't.

As for pulling and updating, this is my last JQM project. I'll be moving on to a platform that's actually being maintained... perhaps Ionic.

ppetree avatar Jun 06 '18 20:06 ppetree

@ppetree I am sorry that you couldn't get the Subpage widget to work. I took a look at my 1 remaining JQM based web production app and it still does work with JQM 1.4.5. and JQuery 1.11 . You can see it in action at ABL Mobile . Follow the info icon at the top left and you will hit the Subpage code. You could utilize Chrome dev tools to see how it works.

ToddThomson avatar Jun 06 '18 21:06 ToddThomson

@ppetree Link fixed.

ToddThomson avatar Jun 06 '18 21:06 ToddThomson