Toby Roseman

Results 543 comments of Toby Roseman

This works fine for me on macOS 10.15 using the [style transfer data from our user guide](https://apple.github.io/turicreate/docs/userguide/style_transfer/). @Vozf - can you reproduce this issue using that dataset? What operating system...

I'm not able to reproduce this issue. The following code works: ```python import turicreate as tc sf = tc.SFrame({'a': range(10)}) sf.save('/tmp/this/folder/does/not/exist') ``` It creates the directory structure and save the...

Surprisingly, the error message is not actually generated by TuriCreate. It's generate by [`std::strerror`](https://github.com/apple/turicreate/blob/01c23080e5934c0bc11c1c89e7fa73fe93a3e3c4/src/core/logging/logger.hpp#L429). There might be some more going on here. We probably don't want to just blindly change...

Looking at the [API docs](https://apple.github.io/turicreate/docs/api/generated/turicreate.style_transfer.create.html#turicreate.style_transfer.create)`_advanced_parameters` is getting treated as part of the `kwargs`. Looking at [the implementation](https://github.com/apple/turicreate/blob/a3d087f531b70ed66d5ed5007b2c639674a149f2/src/python/turicreate/toolkits/style_transfer/style_transfer.py#L45) for `tc.style_transfer.create`, `_advanced_parameters` [will get added to the `params` variable](https://github.com/apple/turicreate/blob/a3d087f531b70ed66d5ed5007b2c639674a149f2/src/python/turicreate/toolkits/style_transfer/style_transfer.py#L194-L202). However it doesn't...

It looks like the parameters you want are still in the code. There is just no way to modify them using our API. If you want to change those values,...

> Unfortunately this doesnt seem to work (i have managed to get colabs and gpu working, but the parameters still dont change)- i know it should but not sure why...

@guihao-liang - As we discussed it would in person, it would be better if progress was reported at fixed time interval rather then every time a 64MB block is uploaded/downloaded....

@KaunilD - That sounds good. I've assigned this issue to you. Both [SArray](https://github.com/apple/turicreate/blob/a89e203d60529d2d72547c03ec9753ea979ee342/src/python/turicreate/data_structures/sarray.py#L1363) and [SFrame](https://github.com/apple/turicreate/blob/a89e203d60529d2d72547c03ec9753ea979ee342/src/python/turicreate/data_structures/sframe.py#L3798) already override `__getitem__`. We will also need unit tests for both [SArray](https://github.com/apple/turicreate/blob/master/src/python/turicreate/test/test_sarray.py) and [SFrame](https://github.com/apple/turicreate/blob/master/src/python/turicreate/test/test_sframe.py), for...

Hi @KaunilD - Yes, SArrays are immutable and that's an important constraint we'll want to keep. Implementing this change in C++ would certainly be ideal, but I'd be fine with...