sqlmesh icon indicating copy to clipboard operation
sqlmesh copied to clipboard

Fix: Embedded Model Type Should Not Accept Any Audit

Open bearInTheRoad opened this issue 2 months ago • 3 comments

This is to fix #5546. After the fix, EMBEDDED model will reject any audit in model definition.

bearInTheRoad avatar Nov 04 '25 13:11 bearInTheRoad

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 04 '25 13:11 CLAassistant

@bearInTheRoad can you please remove the test from here https://github.com/TobikoData/sqlmesh/blob/main/examples/sushi_dbt/models/schema.yml#L45-L46 so that the migration_test passes

izeigerman avatar Nov 05 '25 17:11 izeigerman

@bearInTheRoad can you please remove the test from here https://github.com/TobikoData/sqlmesh/blob/main/examples/sushi_dbt/models/schema.yml#L45-L46 so that the migration_test passes

Hey @izeigerman, I've removed this test in my branch but seems like migration_test fails because it's using code from the old tag.

Should I update dbt/basemodel.py and skip ephemeral models for backward compatible purpose? Or do you prefer we stay this way and merge?

bearInTheRoad avatar Nov 06 '25 13:11 bearInTheRoad