Tobi

Results 189 comments of Tobi

I deleted my local config to fix this problem

I closed it due to the lack of respone by the bitwarden team. But I can reopen it, if you want.

Yes tooltips sound also good. > For the 'tour', will we just use https://github.com/apl-devs/AppIntro? (Off-topic: how did you make those 'screenshots'?) @wb9688 Yes I used AppIntro. With implementing I meant...

please fill out the template properly and add screen recordings

> Task :app:runKtlint /home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt:151:85: Unnecessary semicolon (no-semi) /home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/PlayerService.kt:152:72: Unnecessary semicolon (no-semi)

I fixed this in https://github.com/TeamNewPipe/NewPipe/commit/40caeb465d44a2c5708f62191c259f57076a343e so a rebase should make the checks pass.

LGTM, but the mock tests were executed slower with these changes included (ca. 300ms additional runtime on average over 10 runs). However, I do not know how the Junit tests...

> just release beta versions as beta/unstable versions in fdroid in main app's page That's indeed a good idea.

Regarding outdated libs: #11202 should be implemented once this is merged.

We still provide the beta and legacy app icons: https://newpipe.net/press/logo/ Should be easy to fix