ttkthemes icon indicating copy to clipboard operation
ttkthemes copied to clipboard

Report theme formatting oddities and ui inconsistencies here

Open RedFantom opened this issue 6 years ago • 13 comments

None of the themes provided in this repository are perfect. In fact, most contain some small visual errors, that may only become apparent in specific use-cases. If you spot any, please post a screenshot of the afflicted UI elements here, along with a short description of what you think is off. If you provide a clear example of what is wrong, I will fix the issue!

TODO List

  • [ ] Adapta
    • [ ] Spinbox
    • [ ] Treeview Arrows
  • [ ] Aquativo
    • [ ] Missing: Entry and related images for Spinbox and Combobox
    • [ ] Missing: Progressbar
    • [ ] Spinbox
    • [ ] Entry
    • [ ] Combobox
    • [ ] OptionMenu graphics glitches
    • [ ] Disabled background
    • [ ] Notebook non-selected tab glitch
    • [ ] Scale: Through when setting sticky
  • [ ] Arc
    • [ ] Progressbar when setting sticky
  • [ ] Equilux
    • [ ] Spinbox button arrow button alignment
    • [ ] Progressbar when setting sticky
    • [ ] Button, Checkbutton, Radiobutton contrasting background
    • [ ] Combobox button on the right padding
  • [ ] itft1
    • [ ] Notebook: Selected tab marking
    • [ ] Missing: OptionMenu, Menubutton
  • [ ] Yaru
    • [ ] Spinbox button glitches
    • [ ] Progressbar when setting sticky
    • [ ] Combobox: small artifact around the button

RedFantom avatar Aug 19 '18 12:08 RedFantom

image 'Black' theme: Spinbox text not visible unless selected. TSpinbox should have same settings as TCombobox and TEntry. (foreground='black', padding=2)

kev-a-s avatar Jul 25 '20 14:07 kev-a-s

Thanks for reporting this. I have ran across this too but I forgot to report it here.

Akuli avatar Jul 25 '20 15:07 Akuli

Adapta:

image Spinbox is not styled (you commented out the whole spinbox-part, images missing)

image Notebook client is too contrasty, does not fit the theme (you commented out the Notebook.client-part, image missing)

image Treview.indicator does not fit the theme (you commented out that part, image missing)

And there are many unnecessary images in the folder.

rdbende avatar Feb 18 '21 12:02 rdbende

Aquativo:

image image The radio and checkbuttons have a different background color when disabled, which is not good (-disabledbackground is missing from the code): image

rdbende avatar Feb 18 '21 13:02 rdbende

Thank you for reporting these! I've put them on the TODO-list.

I remember working on the Adapta theme and noticing that it lacked some images. I must've forgotten to create them :flushed: .

RedFantom avatar Feb 18 '21 21:02 RedFantom

Do you know if the scrollbars on Mac are style-able?? I've not been able to find a way to make a decent dark themed scrollbar on Mac, and it appears this is the case on ttkthemes as well.

image

EDIT --- hmm... not sure anything can be done about it presently, but let me know. Here's a fascinating paper on the color issues with MacOS and Tkinter for reference. https://www.tcl.tk/community/tcl2019/assets/talk168/Paper.pdf

israel-dryer avatar Aug 27 '21 21:08 israel-dryer

What Tk version are you using? Refering to this issue -> ttk::scrollbar Styling there was a problem like this before version 8.6.10.

And I know from here that Tk on macOS uses HIToolbox instead of Cocoa for scrollbars. This may also be the cause of this problem, but I don't really know.

EDIT: Yeah, the paper you found explains this better than what I found in the meantime.

rdbende avatar Aug 27 '21 22:08 rdbende

Good call. I upgraded via brew and it is now working find.

image I still find it odd that python.org still ships with and recommends tcl/tk 8.6.8 on Mac, while Mac ships with 8.6.9 natively, and 8.6.11 is available if you upgrade via brew.

Ugh... wondering if dealing with MacOs is worth the trouble... lol

israel-dryer avatar Aug 29 '21 18:08 israel-dryer

'Black' theme: Spinbox text not visible unless selected.

Any update on this? It is still broken after pip install --upgrade ttkthemes

Akuli avatar Oct 03 '21 10:10 Akuli

@Akuli PR created

rdbende avatar Oct 03 '21 11:10 rdbende

@rdbende Thank you, it is merged!

RedFantom avatar Oct 08 '21 20:10 RedFantom

https://imgur.com/a/SOfycZL

I'd like to request changing the color of the treeview widget so it's all in dark grey.

Arrinao avatar Oct 19 '21 18:10 Arrinao

In several themes, when using icons of bigger sizes, Button widgets don't adapt to contain them, so the icon is partially placed outside the widget. Adding or removing a text label to the button doesn't make any difference, and neither does changing the compound value. See this picture with the Clearlooks theme on Windows 10: ttk buttons The issue doesn't happen when styling the button with the Toolbutton style, but this changes its look, so it isn't always the best solution. The affected themes are blue, clearlooks, elegance, kroc, radiance, ubuntu and smog; all the other themes don't have this issue.

Elvish-Hunter avatar Nov 30 '23 19:11 Elvish-Hunter