python-tksvg icon indicating copy to clipboard operation
python-tksvg copied to clipboard

Migrate to pyproject.toml and scikit-build-core

Open mochaaP opened this issue 1 year ago • 10 comments

Tested on py3.12/py3.10/py3.8/pypy3.10 Fedora Linux, py3.12 MSVC, py3.12 macOS 10.15

TODO:

mochaaP avatar Feb 29 '24 13:02 mochaaP

Snippet for testing:

cd tests
import tkinter as tk
import tksvg

window = tk.Tk()
svg_image = tksvg.SvgImage(file="orb.svg")
label = tk.Label(image=svg_image)
label.pack()
window.mainloop()

mochaaP avatar Feb 29 '24 18:02 mochaaP

prebuilt wheels: https://github.com/mcha-forks/python-tksvg/actions/runs/8101063696

mochaaP avatar Feb 29 '24 18:02 mochaaP

cc @rdbende @RedFantom any interests in this?

mochaaP avatar Mar 01 '24 12:03 mochaaP

Yup, absolutely, this is amazing! I'll find some time to review it. I'm not sure, when will @RedFantom have time to merge it though

rdbende avatar Mar 01 '24 12:03 rdbende

Should I also make the same change to gttk & tkextrafont?

mochaaP avatar Mar 01 '24 12:03 mochaaP

Actually, that would be awesome. I tried to tackle that multiple times, but always gave up. However that would make the project much more maintainable.

rdbende avatar Mar 01 '24 12:03 rdbende

Nice! working on it. :)

mochaaP avatar Mar 01 '24 12:03 mochaaP

The new build system is definitely more straightforward and easier to maintain than the existing appveyor. In addition we will no longer have to backport every upstream change manually, as they are now submodules.

Many thanks for this!

rdbende avatar Mar 02 '24 08:03 rdbende

Hmm, CI breaks on macos-14-arm64 20240219.1 but not 20240116.1 due to a linkage error (target mismatch - needed arm64, presented arm64e)

Filed an issue here: https://github.com/actions/runner-images/issues/9441, will need further investigation

edit: applied a workaround by using Homebrew's tcl-tk. Cross-compiling / building fat binaries aren't possible for now. Further tracked at https://feedbackassistant.apple.com/feedback/13673316

mochaaP avatar Mar 03 '24 13:03 mochaaP

closes #3 supersedes #1 #4

mochaaP avatar Mar 04 '24 17:03 mochaaP

@mochaaP thanks a lot for your work!

rdbende avatar Sep 24 '24 10:09 rdbende