pysimdjson icon indicating copy to clipboard operation
pysimdjson copied to clipboard

Provide the ability to link to system simdjson

Open mgorny opened this issue 3 years ago • 2 comments

Bundling a library is a serious sin in our book, so provide the ability to link to the system library. I've also done some refactoring to avoid exponential growth of Extension calls. The default behavior remains the same, so it shouldn't affect existing users.

That said, the patch isn't perfect. It still uses the bundled headers instead of system headers but it should be good enough for us.

mgorny avatar May 23 '21 06:05 mgorny

Happy to support this as an opt-in. I'm assuming this is for Gentoo, in which case the package maintainer will ensure its linking against the right version? Or do we need to do a sanity in the setup.py?

TkTech avatar May 23 '21 15:05 TkTech

Yes, we'll handle the right deps ourselves, as well as stripping simdjson.h to ensure linking against the system header (I couldn't think of an easy way to do that).

mgorny avatar May 23 '21 15:05 mgorny