notifico icon indicating copy to clipboard operation
notifico copied to clipboard

Ignore status from pull requests

Open Mikaela opened this issue 8 years ago • 3 comments

ZNC attempted moving from GitHub IRC hook & Travis notifications to Notifico (https://github.com/znc/znc/issues/1088) to avoid forks spamming ZNC channels with their build status (https://github.com/travis-ci/travis-ci/issues/1094).

However it seems that Notifico announces Travis & Appveyor (& maybe Coveralls) status of pull requests to channel when GitHub is configured to send everything and that is unneeded and spammy.

Another issue which ZNC encountered is already reported https://github.com/notifico/notifico/issues/94.

Mikaela avatar Oct 24 '15 11:10 Mikaela

I don't understand the problem. The issue is that Notifico forwards status messages, which can easily be disabled in the webhook settings? If this is the case, then the real issue is the lazy user who doesn't configure the webhook correctly.

Dav1dde avatar Oct 24 '15 12:10 Dav1dde

Status messages appear for 2 reasons:

  • a new commit was pushed
  • a pull request opened/updated.

For pushes, it's useful to see statuses on IRC channel. For pull requests, it's useful to see their statuses in pull request itself in github GUI, but not on IRC channel. Especially when these messages don't say the reason:

<Not-6fa5> [znc] Success. The Travis CI build passed - https://travis-ci.org/znc/znc/builds/87180844

What exactly succeeded? Push to master (or to some other branch?), or some pull request (if so, which one?)

DarthGandalf avatar Oct 24 '15 13:10 DarthGandalf

Thanks for clarifying, I see the issue now.

Dav1dde avatar Oct 24 '15 14:10 Dav1dde