django-rest-auth icon indicating copy to clipboard operation
django-rest-auth copied to clipboard

Published 20 hours ago • verified publisher icon Tivix

removed unusable endpoint when ACCOUNT_LOGOUT_ON_GET==False

Open makerGeek opened this issue 6 years ago • 2 comments

This commit removes the GET method from the LogoutView when ACCOUNT_LOGOUT_ON_GET==False. Before this commit, the logout endpoint accepts GET requests and appears in the auto-generated DRF docs, but it's not usable.

makerGeek avatar Oct 08 '18 12:10 makerGeek

Coverage Status

Coverage increased (+0.007%) to 96.372% when pulling efd4d2a1a9b271acc929a3f3517786052084c04f on makerGeek:patch-1 into 479a40d2ccd69d69f7a05d716f30239dd3ef2343 on Tivix:master.

coveralls avatar Oct 08 '18 12:10 coveralls

Hi, as a user of rest-auth, thanks for the contribution! This repo is not maintained anymore, so the development moved to dj-rest-auth. (reference: https://github.com/Tivix/django-rest-auth/issues/568) It may be best, if you move this PR there. (and upgrade to using dj_rest_auth)

new repo link: https://github.com/jazzband/dj-rest-auth (I'm not the upkeeper of that repo, it just makes sense for me to help you merge your PR)

Many Thanks, Barney

BarnabasSzabolcs avatar May 30 '20 01:05 BarnabasSzabolcs