django-rest-auth icon indicating copy to clipboard operation
django-rest-auth copied to clipboard

Disable whitespace trimming in password related serializers

Open parth-verma opened this issue 6 years ago • 4 comments

Disabled password whitespace trimming as that interferes when password ends with a space, which although should be allowed results in a mutated password. Same way, if a user enters 8 black spaces, the password is rejected stating that it is blank.

For more information check: https://github.com/Cloud-CV/EvalAI/issues/1543

parth-verma avatar Aug 24 '18 04:08 parth-verma

Thanks for submitting this PR!

I'm in favor of merging this in. That said, would it make sense to have this as a configurable toggle (with a default to True)?

verkaufer avatar Oct 10 '18 04:10 verkaufer

It would make less sense to add a configurable toggle (since this issue is a bug and not a feature) as mutating the password entered by the user at any point in the lifecycle of the code will have ill effects.

parth-verma avatar Oct 13 '18 07:10 parth-verma

Hey, any update on this?

parth-verma avatar Nov 09 '18 15:11 parth-verma

Hi, as a user of rest-auth, thanks for the contribution! This repo is not maintained anymore, so the development moved to dj-rest-auth. (reference: https://github.com/Tivix/django-rest-auth/issues/568) It may be best, if you move this PR there. (and upgrade to using dj_rest_auth)

new repo link: https://github.com/jazzband/dj-rest-auth (I'm not the upkeeper of that repo, it just makes sense for me to help you merge your PR)

Many Thanks, Barney

BarnabasSzabolcs avatar May 30 '20 01:05 BarnabasSzabolcs