django-rest-auth icon indicating copy to clipboard operation
django-rest-auth copied to clipboard

Changed PasswordChangeSerializer to not include old_password when use…

Open sbenemerito opened this issue 8 years ago • 3 comments

When creating a user account through sociallogin with django-allauth, the user account will have no usable password and will need to set one. Setting OLD_PASSWORD_FIELD_ENABLED to True requires 'old_password' field, which should probably be excluded when setting one.

sbenemerito avatar Sep 17 '17 18:09 sbenemerito

Coverage Status

Coverage remained the same at 96.931% when pulling b002ee3d4b4f516f6c451300bed837d7faf92e39 on sbenemerito:master into 9d1f65eedcd437003f5bef13fdc1f27d0fb0ee1a on Tivix:master.

coveralls avatar Sep 17 '17 18:09 coveralls

@maxim-kht Could this be merged? Now that that #387 is merged, this would complete the social login functionality.

chdsbd avatar Jan 27 '18 23:01 chdsbd

Hi, as a user of rest-auth, thanks for the contribution! This repo is not maintained anymore, so the development moved to dj-rest-auth. (reference: https://github.com/Tivix/django-rest-auth/issues/568) It may be best, if you move this PR there. (and upgrade to using dj_rest_auth)

new repo link: https://github.com/jazzband/dj-rest-auth (I'm not the upkeeper of that repo, it just makes sense for me to help you merge your PR)

Many Thanks, Barney

BarnabasSzabolcs avatar May 30 '20 01:05 BarnabasSzabolcs