django-rest-auth
django-rest-auth copied to clipboard
Tivix
django-rest-knox compatibility
Knox provides more security and more functionality than the standard DRF TokenAuthentication. This PR adds full support for Knox.
The development branch seems somewhat behind, so I've raised this against master, but the tests need a little work. I've hit a wall and would really appreciate some help.
I'm not convinced the Knox tests are using knox.auth.TokenAuthentication as expected, and I cannot write a working test_logout_knox. Everything works as expected during manual testing.
Closes #305
Hi :) What is the status of this PR? It would be nice to have this Knox compatibility merged in. I am available to help with anything if need be :)
That'd be great. Functionally, it's all there - my E2E testing went fine. I had trouble getting unit testing to work, then ran out of time to work on this, so it's in need of some test mastery
@stantond Thank you for this PR. It helped me to add knox to my project with django rest auth.
Actually, to use knox token with django rest auth we need to redefine LoginView, RegisterView. And write create_token and serializer for knox token. So instead of merging this we can just write an instuction of how to achieve this.
Glad it helped!
I used the code, you used the code, other people would have too, so it'll save people time in future to merge it and keep usage easy, or put the required classes in another repo. Otherwise we're just telling people to redo work we've already done!
I would like to see this merged. The default DFT token authentication is rather terrible compared to Knox.
So is there any chance that this will get merged? Knox is quite nice and nifty, and the current of compatibility in the main branch is rather disappointing.
Hi @stantond, I consider your PR especially important, since we should really expect a user to get logged out from a single session only, on logout.
As a user of rest-auth, thanks for the contribution!
Unfortunately, this repo is not maintained anymore, Tivix does not seem to respond at all, so the development moved to dj-rest-auth. (reference: https://github.com/Tivix/django-rest-auth/issues/568) Can you please move this PR there? (and upgrade to using dj_rest_auth) I also let the other PR-s know about this, so I expect/hope lots of updates are coming soon in dj_rest_auth, that didn't get merged here.
new repo link: https://github.com/jazzband/dj-rest-auth (I'm not the upkeeper of that repo, it just makes sense for me to help you merge your PR)
Many Thanks, Barney
