tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

🧑‍💻 Define `PatchPredictor`

Open shaneahmed opened this issue 1 year ago • 4 comments

shaneahmed avatar Feb 09 '24 12:02 shaneahmed

Codecov Report

Attention: Patch coverage is 84.21053% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 89.48%. Comparing base (d84ab45) to head (6a360ad). Report is 239 commits behind head on dev-define-engines-abc.

:exclamation: Current head 6a360ad differs from pull request most recent head dad0a98. Consider uploading reports for the commit dad0a98 to get more accurate results

Files Patch % Lines
tiatoolbox/models/engine/engine_abc.py 85.71% 5 Missing and 8 partials :warning:
tiatoolbox/utils/misc.py 80.95% 4 Missing and 4 partials :warning:
Additional details and impacted files
@@                     Coverage Diff                     @@
##           dev-define-engines-abc     #783       +/-   ##
===========================================================
- Coverage                   99.77%   89.48%   -10.30%     
===========================================================
  Files                          63       71        +8     
  Lines                        6784     8760     +1976     
  Branches                     1352     1688      +336     
===========================================================
+ Hits                         6769     7839     +1070     
- Misses                          7      893      +886     
- Partials                        8       28       +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 09 '24 12:02 codecov[bot]

Thank you @shaneahmed @AbishekRajVG for your work on this PR. Only minor comments from my side. I have run the newly added tests and they passed okay.

Abdol avatar Mar 01 '24 13:03 Abdol

Thanks Abdullah. However, we will merge #737 first before working on this PR.

shaneahmed avatar Mar 01 '24 13:03 shaneahmed