tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

Published 20 hours ago • verified publisher icon TissueImageAnalytics

NucleusInstanceSegmentor.predict() has no "patch" mode

Open alevangel opened this issue 1 year ago • 2 comments

  • TIA Toolbox version: 1.5.1
  • Python version: 3.8
  • Operating System: Windows

What I Did

I would like to do some test with patch mode prediction for Nucleus Instance Segmentation, but I see that is still not implemented?

Here is stated that can be used: https://github.com/TissueImageAnalytics/tiatoolbox/blob/000296305aa1faee5c95bac67ff37a23012ea53e/tiatoolbox/models/engine/semantic_segmentor.py#L1279-L1285

But here we assume that could be only 'tile' or 'wsi': https://github.com/TissueImageAnalytics/tiatoolbox/blob/000296305aa1faee5c95bac67ff37a23012ea53e/tiatoolbox/models/engine/semantic_segmentor.py#L1347-L1349

alevangel avatar Feb 01 '24 14:02 alevangel

We are working on improving the structure of engines in #578

shaneahmed avatar Feb 02 '24 11:02 shaneahmed

We are working on improving the structure of engines in #578

The patch mode should still work as NucleusInstanceSegmentor is inheriting from SemanticSegmentor [doc]

shaneahmed avatar Feb 02 '24 14:02 shaneahmed