TinyCircuits-Thumby-Code-Editor icon indicating copy to clipboard operation
TinyCircuits-Thumby-Code-Editor copied to clipboard

Published 20 hours ago • verified publisher icon TinyCircuits

Degrade gracefully for unsupported browsers

Open ace-dent opened this issue 4 years ago • 4 comments

The readme makes it clear that only specific browsers are supported (due to current adoption of WebSerial). However, many casual users will just try to use the Web IDE in their default (unsupported) browser- which just makes things appear... broken...

Please degrade gracefully. After doing a browser check, warn the user about compatibility issue. Consider allowing certain functions to still be useable- such as the bitmap editor.

ace-dent avatar Oct 30 '21 11:10 ace-dent

This does happen to some level now. This is what happens if you try to use it in Firefox: image Although we do not go through and try to ensure everything works on the unsupported browsers.

ghost avatar Nov 01 '21 14:11 ghost

Doesn't work for me with macOS Safari... no warning box is shown.... :-(

ace-dent avatar Nov 02 '21 20:11 ace-dent

OK, I'll try to implement a check for the Safari browser in the next version of the IDE.

ghost avatar Nov 04 '21 14:11 ghost

Is this still an issue today? Detecting which browser on which OS is a whole can of worms. It's weird that WebSerial is detected in Safari.

The detection happens here: https://github.com/TinyCircuits/TinyCircuits-Thumby-Code-Editor/blob/430a4b2b5b5e03d68fe832d050ff902bcad05482/js/repl.js#L55-L60

ghost avatar Sep 28 '23 16:09 ghost