bazel-diff icon indicating copy to clipboard operation
bazel-diff copied to clipboard

Change in toolchain definition is not detected?

Open weedless opened this issue 3 years ago • 1 comments

Hi!

I am working with a C++ project and wanted to apply bazel-diff there. When I do changes in a toolchain definition (e.g. in a typical cc_toolchain_config.bzl file) it seems not to be detected.

Bazel handles toolchain resolution implicit to the target definitions. Could it be that bazel-diff misses those dependencies when it runs a normal query? In our project we add toolchains using the command line parameter --extra_toolchains which is not supported when running a bazel query.

weedless avatar Jan 14 '22 14:01 weedless

I think this capability could fix this? https://github.com/Tinder/bazel-diff/commit/3098e2798eb8f35ded18d5b32751fc84f0c762b6

tinder-maxwellelliott avatar Jun 06 '23 13:06 tinder-maxwellelliott