Scarlet icon indicating copy to clipboard operation
Scarlet copied to clipboard

0.2.x: Lifecycle include not required dependencies

Open makarenkoanton opened this issue 6 years ago • 0 comments

Lifecycle module implement some other modules but not use it.

For example I save 1mb just exclude all modules, which I don't use, but lifecycle implement.

       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-message-adapter-builtin'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-message-adapter-jackson'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-message-adapter-moshi'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-message-adapter-protobuf'

       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-stream-adapter-builtin'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-stream-adapter-coroutines'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-stream-adapter-rxjava'

       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-mqtt'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-socketio-client'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-socketio-mockserver'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-sse-okhttp'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-stomp'
       exclude group: 'com.github.tinder.scarlet', module: 'scarlet-protocol-websocket-mockserver'

All work fine after this. And when use firebase-in-message and scarlet with lifecycle you have @aaaldo 's problem. (protobuf conflict dependencies)

makarenkoanton avatar Jul 15 '19 18:07 makarenkoanton