Scarlet icon indicating copy to clipboard operation
Scarlet copied to clipboard

is Tinder/Scarlet alive?

Open ilyaklyukin opened this issue 5 years ago • 9 comments

Is Tinder/Scarlet alive?

  • Last commit in master was 4 months ago
  • PR are not merged
  • v.0.2.x is not published (I have to use 0.2.5-SNAPSHOT).

Who is responsible for approving PRs? I've spent a lot of time for adding this library in my project, but now I'm stuck with some critical issues:

  • can't initiate reconnection when server closes WS connection (lifecycleRegistry.onNext(LifecycleState.Started) does nothing in this case).
  • in case of no network (turned off WiFi), scarlet continues to reconnect even is app is paused (and establishes connection in foreground when wifi is swithed on!)

I much appreciate greate work that was done here, gson adapter, coroutines, retrofit-like config, but now I'm very doubt of using it in production.

ilyaklyukin avatar Nov 19 '19 14:11 ilyaklyukin

0.2.x is still experimental. to grab a non-snapshot version, 0.2.4 is still available via jitpack. Hopefully I'll have time to publish 0.2.5 soon.

Scarlet powers Tinder's messages/matches every single minute. If you have issues integrating with it, can you create separate issues or link to existing issues, so we can triage those tickets and prioritize bug fixing.

aaronweihe avatar Nov 21 '19 05:11 aaronweihe

@aaronhe42 thanks for the response. 1st issue seems like described here (thus I use not lifecycleOnwer) https://github.com/Tinder/Scarlet/issues/118

2nd is similar to it, the difference only that when our backend closes WS connection with special code (so client knows the reason), I can't initiate reconnection from the client with the call (nothing happens): lifecycleRegistry.onNext(LifecycleState.Started)

https://github.com/Tinder/Scarlet/issues/80

ilyaklyukin avatar Nov 21 '19 09:11 ilyaklyukin

1st (https://github.com/Tinder/Scarlet/issues/118) I hope to be fixed with PR https://github.com/Tinder/Scarlet/pull/58 - but nobody merges it..

ilyaklyukin avatar Nov 21 '19 09:11 ilyaklyukin

@aaronhe42 any progress? who could merge into 0.2.x , for example, https://github.com/Tinder/Scarlet/pull/58 ?

ilyaklyukin avatar Nov 25 '19 12:11 ilyaklyukin

any news? no commits

ilyaklyukin avatar Dec 19 '19 13:12 ilyaklyukin

Waiting for updates in 0.2.x branch Dreams about migration from rxJava to Coroutines

SteinerOk avatar Jan 18 '20 23:01 SteinerOk

is there any updates about #80 ?

muhammadFawzy avatar May 07 '20 11:05 muhammadFawzy

Guys I think we should create a new web socket library based on this one. It's ridiculous how they don't care about this project. I have seen so many good PRs and issues with no answers.

cfva14 avatar Sep 27 '20 13:09 cfva14

Seriously what is going on

thesultanster avatar Feb 11 '21 20:02 thesultanster