Timothy Gu

Results 56 issues of Timothy Gu

Right now, we implement wrapping/unwrapping of IDL objects through a symbol: https://github.com/jsdom/webidl2js/blob/ab63e7e8ed59659dd961eef0ac0e56060db19870/lib/output/utils.js#L61-L77 However, this is not only allows client scripts to escape the jsdom environment, it also fools brand checks...

jsdom PR: https://github.com/tmpvar/jsdom/pull/2092 Closes https://github.com/jsdom/webidl2js/issues/59 in the process.

This PR forces all interfaces annotated with [PrimaryGlobal] or [Global] and that supports named getter to become factories, the reasoning being that [[[GetOwnProperty]]](https://heycam.github.io/webidl/#named-properties-object-getownproperty) of the named properties object (which is...

Due to the way we construct type conversions, oftentimes we see unidiomatic code like https://github.com/jsdom/webidl2js/blob/7d45dfc6e6d1ba737b77eaabbab712dcf2d19435/test/__snapshots__/test.js.snap#L167 Ideally we want to merge string literals together and even use template literals. Related to...

## The Problem A giant project like [jsdom](https://github.com/tmpvar/jsdom) inevitably [requires](https://github.com/tmpvar/jsdom/blob/fc09f64ed91054c32ff0ce2186d4aa1fb70bb260/package.json#L19-L42) many different modules to provide certain features. Some of these features are specified using Web IDL, like [`URL`](https://github.com/jsdom/whatwg-url/blob/be9038b00a2a1da7a5b4717cee13e4c734e10d8a/src/URL.idl), [`URLSearchParams`](https://github.com/jsdom/whatwg-url/blob/be9038b00a2a1da7a5b4717cee13e4c734e10d8a/src/URLSearchParams.idl), and...

See https://heycam.github.io/webidl/#es-default-tojson.

We currently have an incomplete version of the actual algorithms: https://github.com/jsdom/webidl2js/blob/bf9954ddc186e4d733957aba0bdcde35366fb548/lib/constructs/operation.js#L88-L98 Would be nice to factor it out, for e.g. callback function support.

I am sure this is on someone's TODO list but just adding a bug to track it. By dedicated documentation, I mean a website with all the API methods, options,...

enhancement
documentation

(Migrated from tj/ejs#192) See https://github.com/mde/ejs/blob/master/lib/ejs.js#L389: ``` js options.delimiter = opts.delimiter || exports.delimiter || _DEFAULT_DELIMITER; ``` It is possible to set `delimiter` globally. Why not enable this feature for all options...

enhancement

Jade has been renamed to Pug, and it's appropriate for this module to depend on Pug instead of Jade now. I also volunteer to maintain this under the umbrella of...