Timothy

Results 153 comments of Timothy

> > Would you mind adding some Unit test? I've added recently all the necessary tools to add them. > > @TimoPtr testing is hard with the DataLayer. In either...

@yschimke do you plan to continue this PR?

> @TimoPtr I forgot about your suggestion of no setting, and added one. Should I remove? I'm fine with the settings on the watch. You'll need to add a screenshot...

> Spent too much time on what I thought would be a quick fix. If I find some time later, I'll pick it up and continue. > > Thanks for...

@yschimke would you mind have a quick look to my changes?

> LGTM, thanks. > > I'd suggest living with testing `dnsRequest` instead of `onRequest` because it keeps the tests much simpler. Indeed, I didn't see during the review that it...

Multiple comments aren't addressed. Please take a look to them before asking for re-review. Also I would like @jpelgrom opinion on the architecture since he was the one initially thinking...

> I'm not sure this is something for the app to handle because: > > * the behavior change you linked is "Android will do something" > > * password...

Indeed we cannot catch all of them, we could see we the frontend if we can send them a flag that the app is being recorded. I think it is...

This requirements is not a must have for targeting android API 36