Tim Hutt

Pre-commit install hook doesn't actually install Pyright

5

Pyright is only actually installed on the first use. This makes installing Pyright in a docker image so you avoid re-downloading it for every CI run (and depending on unreliable...

Don't require a root node up-front

2

First I want to say this is a great library! However I ran into a little snag which is that you require creating a root node up front. That feels...

Unfortunately this is with proprietary data so I can't give a full reproducer but I do these queries with `duckdb-rs` 0.9.2: * `CREATE TABLE queue as SELECT * FROM read_json_auto('example.json');`...

column_count can panic

2

`Statement::column_count()` just returns a `usize`, yet it can easily fail. In that case it panics because it calls `result_unwrap()` as shown by this backtrace. ``` 4: duckdb::raw_statement::RawStatement::result_unwrap at .../.cargo/registry/src/index.crates.io-6f17d22bba15001f/duckdb-0.9.2/src/raw_statement.rs:72:9 5:...

Not sure what else to add. I'm using a Mac.

I can save files, I think, but it never clears the dirty flag for some reason.

Support stdin/stdout (io-std feature) in WASM

5

The `wasm32-wasi` target does support stdio, however Tokio implements stdin/stdout by spawning a new thread and using blocking IO: ``` cfg_io_std! { /// A handle to the standard input stream...

Support wasi-cli (stdin, stdout)

1

Currently you can't use Tokio's stdin/stdout support (the `io-std` feature flag) on WASI. But WASI does support that in [wasi-cli](https://github.com/WebAssembly/wasi-cli). I believe it is supported by Node now. This would...

CMO exceptions don't look quite right

27

The CMO/prefetch exceptions are: ``` ifdef::cbo_clean_flush[] | Permission violation | It does not grant and | Length violation | At least one byte accessed is within the bounds endif::cbo_clean_flush[] ifdef::cbo_inval[]...

Extension names don't follow the official convention

1

Very minor but we have `Zcheripurecap`, `Zcheripte`, `Zcherilegacy`, `Zstid`, From the unprivileged spec: > The first letter following the "Z" conventionally indicates the most closely related alphabetical extension category, IMAFDQCVH....