Tim Hutt comments

Results 711 comments of


                                            Tim Hutt

Add a lexer for RISC-V assembly

@tancnle any chance you could review this?

Implementing callbacks in sail-riscv for state-changing events

It's something like this in C++ (adapted from our code, so this exact code isn't tested). ``` std::vector readLbits(lbits val) { std::vector data(val.len); // We should really double check the...

Implementing callbacks in sail-riscv for state-changing events

> mpz_sizeinbase(val.bits, 2) + 7) / 8 Actually reading this back, I wonder if `mpz_sizeinbase(val.bits, 256)` would work (and not be really slow).

Implementing callbacks in sail-riscv for state-changing events

> I would like to point out that the callback functions are annotated as `pure`. But in reality we have no way to guarantee that users will not actually change...

Implementing callbacks in sail-riscv for state-changing events

Yeah to be clear I don't think these callbacks should be user defined. We should have hard-coded callbacks that support RVFI, logging, etc.

Implementing callbacks in sail-riscv for state-changing events

Hi, sorry for not getting around to this. Just wanted to say it's still on my todo list and I will get to it!

Implementing callbacks in sail-riscv for state-changing events

@kseniadobrovolskaya would it be ok if I did a bit of work on this and pushed to this branch?

Implementing callbacks in sail-riscv for state-changing events

> Any updates on this? > do you imply that you going to fix the pending comments from you, or should I continue to work on them? Yes, at least...

Implementing callbacks in sail-riscv for state-changing events

I squashed, rebased and commented out `mstatus` tracking since it doesn't compile currently. Also there are linker errors because the C file is no longer compiled in (we don't want...

Implementing callbacks in sail-riscv for state-changing events

Yeah I don't have any time right now so go ahead! I'll post a message if I'm going to start working on it.