Tim Hutt

Results 713 comments of Tim Hutt

The very small changes I was referring to are demonstrated in the screenshot.

I'll make a PR for the base instructions as I suggested, and I'll try and do one for `mstatus` too since that is a bigger change and probably more debatable!

Ok now I'm even more confused! :-D So are you saying that in the example the overall physical read/write (both red boxes) could be a "single access" even though they...

This is still very unclear to me. > No, what Andrew was saying is that an overall access by a load/store instruction may be performed as one memory access or...

Ok but either way it *could* be decomposed into multiple accesses, so the question still stands. *If it does* decompose it into two physical accesses and they match different PMP...

Ah ok, I think I didn't follow because you said the blue box is a valid outcome, but that's not a physical memory access. So would you say this is...

That makes sense, thank you! > a subset of the original access may be performed Ah is this what defines an "access" - something that will be performed in its...

Ah interesting. That seems slightly inconsistent with the PMP spec wording then. If a memory-access instruction (e.g. `lw`) leads to a single "access" that is performed using 1 or more...

Yes I quoted that section. It's very clear for RV64 where `instret` (which isn't really a CSR) is exactly equal to `minstret`. But on RV32 it is split between `minstret`...

Ok it's very very verbose! So this is just the output from when I type the `o` of `Deno`: ``` {"type":"mark","name":"did_change","count":8,"args":{"textDocument":{"uri":"file:///Users/timh/d1/main.ts","version":9},"contentChanges":[{"range":{"start":{"line":2,"character":3},"end":{"line":2,"character":3}},"rangeLength":0,"text":"o"}]}}, {"type":"measure","name":"did_change","count":8,"duration":0}, {"type":"mark","name":"completion","count":2,"args":{"textDocument":{"uri":"file:///Users/timh/d1/main.ts"},"position":{"line":2,"character":4},"context":{"triggerKind":1}}}, {"type":"mark","name":"get_line_index_sync","count":28,"args":{"specifier":"file:///Users/timh/d1/main.ts"}}, {"type":"measure","name":"get_line_index_sync","count":28,"duration":0}, {"type":"mark","name":"request","count":37,"args":{"id":38,"method":"getCompletions","specifier":"file:///Users/timh/d1/main.ts","position":29,"preferences":{"includeCompletionsWithInsertText":true}}}, {"type":"mark","name":"op_script_version","count":105,"args":{"specifier":"file:///Users/timh/d1/main.ts"}}, {"type":"measure","name":"op_script_version","count":105,"duration":0}, {"type":"mark","name":"op_script_version","count":106,"args":{"specifier":"file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/lib.dom.d.ts"}}, {"type":"measure","name":"op_script_version","count":106,"duration":0},...