Timemaster99
Timemaster99
> Just editing the comment to provide more context rather than being rude; > > it's up to you whether or not you fix it. It's easy to argue that...
Updated the description just a bit to reflect more features
Did not mean to request death on this, I think github did it for me. Whoever reviews can remove that
survived the upstream merge, expected much worse
> Any idea if/when this'll be merged? Will be merged when Null gets to it. This changes over 300 files, so it's understandable that it'll be slow to review
Test fail invalid, MobRandomServiceCorpse did it
> Just at a quick glance I spot several changes in base files that aren't commented. I can put a comment on all of them, but I feel like that'd...
I need the Delta to unassign this PR's reviewer at some point, since they're no longer with us (fly high)
Test fails are related to protolathe, grille, and other structure construction. Those aren't touched in this PR, so invalid test fail. Seems like this is happening to all PRs
> Actually a majority of the test fails look legitimate to me. You would think, but all of these test fails (BucklePullTest, InsertEjectBuiTest, NoStaticPriceAndStackPrice, ClimbTableTest, TestSuicideByHeldItem, TestSuicide, TestSuicideByHeldItemSpreadDamage, ChangeComputer, TestSuicideWhileDamaged,...