node-sqlserver-v8
node-sqlserver-v8 copied to clipboard
TimelordUK
Can I do a PR to remove prebuild-install as dependency
Hi there.
I love this project. It's small and very tiny. Unfortunately it has one minor problem. Prebuild-install:
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| | `-- [email protected]
| | `-- [email protected]
| `-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected] deduped
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected] deduped
| | `-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected] deduped
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | `-- [email protected]
| | +-- [email protected]
| | | +-- [email protected]
| | | | +-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected] deduped
| | | `-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected] deduped
| | `-- [email protected]
| `-- [email protected]
| `-- [email protected]
That is A LOT of dependencies for what is essentially not needed for running sqlserver-v8, only for installation. I've actually done work in this before where a custom script was used that did most of the work and used internal commands (like tar, which is built into any linux systems and windows system) among other things.
Can I do the same here? Otherwise I'm just gonna have to fork, make my changes and release them with -lite after the name.
What would be the benefit of switching to custom scripts? Presumably if you care about space you're using a bundler which would not include prebuild-install and it's dependencies in your build. This seems like it would save a few milliseconds on install in exchange for increased complexity.
I just don't like installing (and running for that matter) a ton of random code that is hard to audit onto production servers. Especially when none of it is related to the actual library or needed for the library.