node-ytpl icon indicating copy to clipboard operation
node-ytpl copied to clipboard

fix: Handle empty playlist

Open Hazmi35 opened this issue 2 years ago • 8 comments

This should fix #121

Hazmi35 avatar Aug 30 '21 06:08 Hazmi35

Should test for empty playlist created too?

Hazmi35 avatar Aug 30 '21 06:08 Hazmi35

would be cool 😅

TimeForANinja avatar Sep 06 '21 21:09 TimeForANinja

Codecov Report

Merging #122 (d3519ab) into master (fcc26a1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          260       261    +1     
=========================================
+ Hits           260       261    +1     
Impacted Files Coverage Δ
lib/main.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcc26a1...d3519ab. Read the comment docs.

codecov[bot] avatar Sep 06 '21 21:09 codecov[bot]

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

TimeForANinja avatar Sep 06 '21 21:09 TimeForANinja

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

Yes, I didn't think of that before, changed in d3519ab6f1b2929ba1a673191223d5e2bf8f6643.

Do the test still need to be created?

Hazmi35 avatar Sep 08 '21 13:09 Hazmi35

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 07 '21 20:11 stale[bot]

This should be reopened when you're ready.

Hazmi35 avatar Nov 15 '21 05:11 Hazmi35

not quite ready but i can at least tell the stale bot to ignore this 😉

TimeForANinja avatar Dec 22 '21 22:12 TimeForANinja