Tim Düsterhus

Results 223 comments of Tim Düsterhus
trafficstars

All the queries for the marking of notifications as read should be cleaned up by now. Now there are several queries including a `confirmTime = 0` and also an `objectID`....

> * `wcf1_like`: The workload is not clear enough to justify a change here. In addition the INSERTs will be “all over the place” due to `userID` being part of...

> * `wcf1_poll_option_vote` This one is barely read from during normal operation. This does not justify a change.

> * `wcf1_article_content` That one already has a PRIMARY KEY that I must've missed.

> * `wcf1_user_collapsible_content` This one is cached in user storage and there's the `resetAll()` method that includes a query that does not include the `userID`. I'm not *that* sure about...

> Use `PRIMARY KEY (userID, trophyID)` > > * Inverted order, because I expect this to mostly search for trophies of a single user. The table is queried with a...

> _Possibly_ add `KEY (groupID)` > > * “find all users in group”. This one was already created implicitly, because of the FOREIGN KEY.

> * `wcf1_like_object` Unfortunately that one also has a PRIMARY KEY with auto increment. And the contents of this table are mapped as a DatabaseObject, so we can't adjust this...