Tim Düsterhus

Reviewed commits (to be edited): - [x] 065fb17 Dissolve direct recursion in function ParseHexZero - [x] f0472c0 Dissolve direct recursion in function ParseMustBeSegmentNzNc - [x] 39c2a81 Dissolve direct recursion in...

I've now looked at all commits, except the ones for indirection recursion. I had quite a bit of trouble following the changes for the functions that were not rewritten into...

> With regard to the commits reviewed so far, I can therefore only say that I didn't see any obvious mistakes, but the amount of code churn doesn't make me...

Review of the updated PR (to be checked off): - [x] 2fc84d0 (HEAD -> issue-282-resolve-parser-recursion, origin/issue-282-resolve-parser-recursion) Dissolve indirect recursion in function ParseOwnHostUserInfoNz - [x] 825a70a Dissolve indirect recursion in function...

I have now looked at all the commits. The two indirect ones look good to me from a correctness perspective. The direct one has the one mistake I pointed out...

Some thoughts from my side regarding the possible concerns from that other issue, specifically: > what is a patch release fixes a regression that was introduced a few days before,...

Related: #172.

It probably is most useful to look into this after #4000 (especially since cancelling is desired).

The automated commit linking doesn't work, since the fix immediately went into older branches. For reference: https://git.haproxy.org/?p=haproxy-3.2.git;a=commitdiff;h=7259dffe8ea5bc820bc7b6d3c2ee0775a09063da

> You already have "http-request reject" to forcefully close the H2 connection. Oh, that's good to know, but it applies too early. I want to close the connection _after_ successfully...