neogit
neogit copied to clipboard
TimUntersberger
Opening fails when in the middle of a bisect and making commits, switching branches etc.
Description
Getting this error when executing neogit.open() doing a bisect, then making commits, checking out branches etc, before stopping the bisect:
Error executing Lua callback: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...cal/share/nvim/lazy/neogit/lua/neogit/lib/git/bisect.lua:92: attempt to index local 'oid' (a nil value)
stack traceback:
[C]: in function 'error'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function 'dispatch_refresh'
...share/nvim/lazy/neogit/lua/neogit/lib/git/repository.lua:200: in function 'instance'
/Users/laytan/.local/share/nvim/lazy/neogit/lua/neogit.lua:113: in function 'open_status_buffer'
/Users/laytan/.local/share/nvim/lazy/neogit/lua/neogit.lua:175: in function 'open'
/Users/laytan/.config/nvim/lua/laytan/plugins/neogit.lua:23: in function </Users/laytan/.config/nvim/lua/laytan/plugins/neogit.lua:22>
Looking at the error it ends up failing here, oid is nil:
https://github.com/NeogitOrg/neogit/blob/757c74cf4d5765d39370ebb48cbcf1ea44c2f84d/lua/neogit/lib/git/bisect.lua#L92
Neovim version
NVIM v0.10.3 Build type: Release LuaJIT 2.1.1713484068
Operating system and version
macOS 15.3.1
Steps to reproduce
nvim -nu minimal.lua:lua require('neogit').open()
Expected behavior
No response
Actual behavior
Error executing Lua callback: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...cal/share/nvim/lazy/neogit/lua/neogit/lib/git/bisect.lua:92: attempt to index local 'oid' (a nil value)
stack traceback:
[C]: in function 'error'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'
...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function 'dispatch_refresh'
...share/nvim/lazy/neogit/lua/neogit/lib/git/repository.lua:200: in function 'instance'
/Users/laytan/.local/share/nvim/lazy/neogit/lua/neogit.lua:113: in function 'open_status_buffer'
/Users/laytan/.local/share/nvim/lazy/neogit/lua/neogit.lua:175: in function 'open'
/Users/laytan/.config/nvim/lua/laytan/plugins/neogit.lua:23: in function </Users/laytan/.config/nvim/lua/laytan/plugins/neogit.lua:22>
Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}
local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
return base_root_path .. "/" .. (path or "")
end
function M.load_plugin(plugin_name, plugin_url)
local package_root = M.root("plugins/")
local install_destination = package_root .. plugin_name
vim.opt.runtimepath:append(install_destination)
if not vim.loop.fs_stat(package_root) then
vim.fn.mkdir(package_root, "p")
end
if not vim.loop.fs_stat(install_destination) then
print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
vim.fn.system({
"git",
"clone",
"--depth=1",
plugin_url,
install_destination,
})
if vim.v.shell_error > 0 then
error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
vim.log.levels.ERROR)
end
end
end
---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>
---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
vim.opt.packpath = {} -- Empty the package path so we use only the plugins specified
vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir
-- Install required plugins
if plugins ~= nil then
for plugin_name, plugin_url in pairs(plugins) do
M.load_plugin(plugin_name, plugin_url)
end
end
vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
vim.env.XDG_DATA_HOME = M.root("xdg/data")
vim.env.XDG_STATE_HOME = M.root("xdg/state")
vim.env.XDG_CACHE_HOME = M.root("xdg/cache")
-- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
vim.api.nvim_create_autocmd("VimLeave", {
callback = function()
vim.fn.system({
"rm",
"-r",
"-f",
M.root("xdg")
})
end
})
end
-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
plenary = "https://github.com/nvim-lua/plenary.nvim.git",
telescope = "https://github.com/nvim-telescope/telescope.nvim",
diffview = "https://github.com/sindrets/diffview.nvim",
neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit
I'm getting the same error after starting a bisect and trying to open neogit while the bisect is still ongoing.
