neogit icon indicating copy to clipboard operation
neogit copied to clipboard

rspec WIP

Open CKolkey opened this issue 10 months ago • 2 comments

experimental RPC test suite

CKolkey avatar Mar 29 '24 22:03 CKolkey

It looks nice. But I am not sure that we need to bring another language to the codebase, which is needed to be supported.

deril avatar Apr 02 '24 11:04 deril

@deril if this was in common lisp, you would have an entirely different attitude :P

CKolkey avatar Apr 02 '24 11:04 CKolkey

I ran out of steam contributing test coverage a while back because some things seemed to be untestable (sorry I would have to dig that out I don’t recall the exact issue), so I would be very interested if this makes things easier/smoother to test!

star-szr avatar May 18 '24 09:05 star-szr

All good, man, I appreciate what you did regardless :)

Yeah, using ruby has a few advantages here:

  • robust git gem to verify correctness
  • non-async runtime
  • robust stdlib for managing child processes/filesystem stuff
  • rspec is a great testing framework

And of course... i thought it would be interesting to use RPC to test neovim. Thats probably the only real reason hahaha.

I guess the downside is that people would have to write tests in ruby, but it's basically just me doing this anyways so... whatever. I like ruby 🤷‍♂️

Oh, and you can only really do E2E tests, but I think thats ok. I already unit test lua stuff when it's hard to get "correct", which wouldn't change.

CKolkey avatar May 18 '24 10:05 CKolkey