Ryan

Results 51 comments of Ryan

Can you recall any parts of the ring gen/mod that is reliant on being planar?

The standard impl in types.rs: ```rs impl Ord for Vertex { fn cmp(&self, other: &Self) -> Ordering { if self.z != other.z { self.z.partial_cmp(&other.z).expect("Non-NAN") } else if self.y != other.y...

> Ideally you should make a new type instead of vertex like normalSliceVertex and impliment ord and tower vertex for it. I have added `NormalVertex` for this, now I will...

Now it's getting up much higher (`layer_count: 562`) before the incomplete rings show up. ```l layer_count: 562 F190604 E57530 F89296 E57533 F89297 layer_count: 563 F184166 E97411 F190603 layer_count: 564 F184166...

Thank you. For future reference: ```rs impl Ord for NormalVertex { fn cmp(&self, other: &Self) -> std::cmp::Ordering { // get the normal to project on for z let normal =...

**It runs, finally!!!** Now the G-code does not contain moves, just the z moves per-layer, I think this means it's time to move on to the plotter.

Looking at the plotter it uses a lot of traits I think I will just change the impls instead of adding a new struct. First I will change stuff like...

I will have to make 3d equivalents of geo polygons.

**True**, a lot of the plotter uses `geo` which only supports 2d geometry; handling this in two ways may end-up with a ton of code duplication. I know that this...

> That's going to be a lot of work. > > The pipeline I was imagining for this would be: >1. Slice the model into a list of 3d points...