Tim Taylor
Tim Taylor
> Actually, I agree with the approach you propose. Do you think it would be valuable to add that statement explicitly somewhere in the package documentation? Yes that's a good...
No worries - next time I look at the package I'll try and take a poke.
@avallecam - I'm working on this at the moment. Plan is two-fold: 1. Document this clearly in the vignette. The included Covid dataset works well for this. 2. Add a...
> Point 1 could briefly add examples using `na.omit()`, `filter(!is.na(cases_new))`, `replace_na(list(cases_new = 0))`, as you wrote in the comment above [#113 (comment)](https://github.com/reconverse/incidence2/issues/113#issuecomment-2031357996) I'm going with the `tidyr::replace_na(list(cases_new = 0))` version...
This makes sense and would be straightforward to implement. I won't be able to implement in the immediate future but will flag with @thibautjombart.
To clarify - the "wish" is for when there is an explicit `i`. I know there are alternatives but I'd still like the default behaviour to be consistent and always...
For reference, [Link](https://stat.ethz.ch/pipermail/r-devel/2021-December/081332.html) to discussion on R-devel. Link jumps you to the middle of the discussion where the beginning of a discussion into glue-style string interpolation comes up. Think there...
Cheers @joshwlambert. Yes this is exactly how I'd handle it (outside of incidence). Will add an example along the lines of ```r outbreaks::ebola_sim_clean$linelist |> pivot_wider(names_from = outcome, values_from = date_of_outcome)...
> * I've been considering it on multiple occasions but I'm still not convinced this should be a `as_incidence()` method. My view of `as_()` methods is that they convert objects...
FWIW (and appreciate these are my unsolicited thoughts). I personally think this should be created in a separate repository and, should @yihui wish, it could be linked to in the...