goodwe-sems-home-assistant icon indicating copy to clipboard operation
goodwe-sems-home-assistant copied to clipboard

Published 20 hours ago • verified publisher icon TimSoethout

brand logo

Open Arrheniu2 opened this issue 1 year ago • 3 comments

Hi, im not sure if is an issue but we cant see the brand sems logo in the integration, maybe we can add it to the home assistants brand logo repositore?

not sure if we can pull that logo there to the domain "sems" or maybe we should host locally or add to this repositore

Arrheniu2 avatar Mar 28 '23 09:03 Arrheniu2

Great idea. Feel free to make a pull request with the required changes. :)

28 Mar 2023 11:13:03 Arrheniu2 @.***>:

Hi, im not sure if is an issue but we cant see the brand sems logo in the integration, maybe we can add it to the home assistants brand logo repositore?

not sure if we can pull that logo there to the domain "sems" or maybe we should host locally or add to this repositore

— Reply to this email directly, view it on GitHub[https://github.com/TimSoethout/goodwe-sems-home-assistant/issues/83], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAEQZ3F5GWGDOCSNNZCJ4FTW6KTQ5ANCNFSM6AAAAAAWKIWDSQ]. You are receiving this because you are subscribed to this thread.[Tracking image][https://github.com/notifications/beacon/AAEQZ3CLC7RKC6MTW5NHMLLW6KTQ5A5CNFSM6AAAAAAWKIWDSSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGD5RTMI.gif]

TimSoethout avatar Mar 28 '23 10:03 TimSoethout

i made my first github pull request here: https://github.com/home-assistant/brands/pull/4251

probably i messed up something but eventually we will get the logo in home assistant (i hope)

thanks for your work, tho. regards

Arrheniu2 avatar Mar 28 '23 11:03 Arrheniu2

I guess you should resubmit that PR with the new Goodwe brand logo which is now a red stylized letter 'W'.

f00f avatar Oct 31 '23 11:10 f00f