arango-migrate icon indicating copy to clipboard operation
arango-migrate copied to clipboard
verified publisher icon TimMikeladze

Missing `--typescript` option for cli

Open grahamlyons opened this issue 10 months ago • 1 comments

The options object for the CLI defines a typescript property: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L17

This is passed into the method to create a new migration: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L55

However, the option doesn't appear to be available on the CLI itself: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d12410591674ad58b756b1e2d220754ecd/README.md#usage

It looks like it was removed a few years ago but I can't see any indication why:

  • commented out - https://github.com/TimMikeladze/arango-migrate/commit/8548dfee5efdff343b9ee68caaf4d6fc1dea4b25#diff-b67825f5189e1999e99eb05158236596f976ef916f734262cb00e631855559b1L27-R27
  • removed completely - https://github.com/TimMikeladze/arango-migrate/commit/d67aa508b7cf8212a08157b8e16359f96dc1ab84#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddL29

Was there a problem with this option?

grahamlyons avatar Mar 08 '25 21:03 grahamlyons

My memory is very hazy on this but I think I had problems with ESM and it just didn’t make sense at the time to fix in terms of priorities. It was a few years ago….only way to confirm would be check out the commit and run it locally.

I’d love a PR that reenables TypeScript support however.

Tim Mikeladze

On Sat, Mar 8, 2025 at 13:55 Graham Lyons @.***> wrote:

The options object for the CLI defines a typescript property: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L17

This is passed into the method to create a new migration: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L55

However, the option doesn't appear to be available on the CLI itself: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d12410591674ad58b756b1e2d220754ecd/README.md#usage

It looks like it was removed a few years ago but I can't see any indication why:

Was there a problem with this option?

— Reply to this email directly, view it on GitHub https://github.com/TimMikeladze/arango-migrate/issues/116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLR7Q6FNU5BR3PZLFBUC32TNRMXAVCNFSM6AAAAABYTO3COCVHI2DSMVQWIX3LMV43ASLTON2WKOZSHEYDKMBTGQ3TMMY . You are receiving this because you are subscribed to this thread.Message ID: @.***> [image: grahamlyons]grahamlyons created an issue (TimMikeladze/arango-migrate#116) https://github.com/TimMikeladze/arango-migrate/issues/116

The options object for the CLI defines a typescript property: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L17

This is passed into the method to create a new migration: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d/src/cli.ts#L55

However, the option doesn't appear to be available on the CLI itself: https://github.com/TimMikeladze/arango-migrate/blob/0cc7c6d12410591674ad58b756b1e2d220754ecd/README.md#usage

It looks like it was removed a few years ago but I can't see any indication why:

Was there a problem with this option?

— Reply to this email directly, view it on GitHub https://github.com/TimMikeladze/arango-migrate/issues/116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLR7Q6FNU5BR3PZLFBUC32TNRMXAVCNFSM6AAAAABYTO3COCVHI2DSMVQWIX3LMV43ASLTON2WKOZSHEYDKMBTGQ3TMMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

TimMikeladze avatar Mar 08 '25 22:03 TimMikeladze