UIOMatic
UIOMatic copied to clipboard
Update umbraco 9
Hi,I did an upgrade to umbraco 9. It's working very well. But I couldn't make a pull request. How can I proceed?
wow sweet @marciogoularte ! well did you make a fork on github? Then you should just be able to create a pull request? https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
alternatively you can also send me the files and I can setup a new branch
@marciogoularte ? Let me know how I can help :)
Hi, i made a pull request. As you may know, Umbraco v9 everything is by DI. We no longer have Umbraco.Core.Composing.Current
. UIOMatic uses static classes using Umbraco v8 Current
, I had to make a service locator. But I believe that temporary, we can improve this
Sweeeeet! Thank you so much. Just need to see how I can merge to a new branch. @marciogoularte
merged to a new branch @marciogoularte , now just need to figure out why the automated build doesn't work
Looking forward to seeing this released!
@marciogoularte mananaged to get the appveyor build working https://www.nuget.org/packages/Nibble.Umbraco.UIOMatic/
not sure if the nuget package needs to change...
Hi @TimGeyssens . I'm not sure either
yeah need to look into it, doesn't seem to do the correct stuff...
I'm trying it out now. I had the issue:
System.InvalidOperationException: Unable to resolve service for type 'UIOMatic.IUIOMaticHelper' while attempting to activate 'UIOMatic.Web.Controllers.UIOMaticTreeController'.
Adding:
services.AddSingleton<IUIOMaticHelper, UIOMaticHelper>();
In my Startup.ConfigureServices
method seemed to help.
Update
I'm trying to upgrade to Umbraco v9 but the site was having a strange issue:
No controller/action found by name Render.Index
My project structure is like:
- Web
- Depends on Nibble.Umbraco.UIOMatic
- Core
- Depends on Nibble.Umbraco.UIOMatic.Core
Seems that Nibble.Umbraco.UIOMatic.Core
depends on Umbraco.Cms.Core ≥ 9.0.0
and Umbraco.Cms ≥ 9.0.0
, but I doubt it should be using Umbraco.Cms
?
I don't want my Core
project to have a sub-dependency of Umbraco.Cms
as it adds files like ~/umbraco/UmbracoWebsite/NoNodes.cshtml
which I think messes with the build.
My site doesn't really need UIOMatic that much so I'm disabling it now. Not looking for a solution anytime soon, thought I'd just add my thoughts.
thanks @Harvzor , yeah the nuget package needs some work, thanks for letting me know
What do i have to do to get this working? Registered .AddUIOMatic() in startup but now i get a null reference exception in /umbraco/ServerVariables: "NullReferenceException: Object reference not set to an instance of an object. UIOMatic.Web.UIOMaticServerVariablesHandler.Handle(ServerVariablesParsingNotification notification)" in backoffice and a bunch of errors from angular.
@marciogoularte any pointers?
What do i have to do to get this working? Registered .AddUIOMatic() in startup but now i get a null reference exception in /umbraco/ServerVariables: "NullReferenceException: Object reference not set to an instance of an object. UIOMatic.Web.UIOMaticServerVariablesHandler.Handle(ServerVariablesParsingNotification notification)" in backoffice and a bunch of errors from angular.
That will be missing config elements in appsettings.json - I commented in more detail in https://github.com/TimGeyssens/UIOMatic/issues/197
version 4.1.0 adds default config