UIOMatic icon indicating copy to clipboard operation
UIOMatic copied to clipboard

Update umbraco 9

Open marciogoularte opened this issue 2 years ago • 16 comments

Hi,I did an upgrade to umbraco 9. It's working very well. But I couldn't make a pull request. How can I proceed?

matic

marciogoularte avatar Sep 26 '21 22:09 marciogoularte

wow sweet @marciogoularte ! well did you make a fork on github? Then you should just be able to create a pull request? https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

TimGeyssens avatar Oct 04 '21 13:10 TimGeyssens

alternatively you can also send me the files and I can setup a new branch

TimGeyssens avatar Oct 04 '21 13:10 TimGeyssens

@marciogoularte ? Let me know how I can help :)

TimGeyssens avatar Oct 12 '21 13:10 TimGeyssens

Hi, i made a pull request. As you may know, Umbraco v9 everything is by DI. We no longer have Umbraco.Core.Composing.Current. UIOMatic uses static classes using Umbraco v8 Current, I had to make a service locator. But I believe that temporary, we can improve this

marciogoularte avatar Oct 12 '21 16:10 marciogoularte

Sweeeeet! Thank you so much. Just need to see how I can merge to a new branch. @marciogoularte

TimGeyssens avatar Oct 14 '21 07:10 TimGeyssens

merged to a new branch @marciogoularte , now just need to figure out why the automated build doesn't work

TimGeyssens avatar Oct 22 '21 11:10 TimGeyssens

Looking forward to seeing this released!

sbosell avatar Oct 26 '21 09:10 sbosell

@marciogoularte mananaged to get the appveyor build working https://www.nuget.org/packages/Nibble.Umbraco.UIOMatic/

TimGeyssens avatar Nov 23 '21 08:11 TimGeyssens

not sure if the nuget package needs to change...

TimGeyssens avatar Nov 23 '21 17:11 TimGeyssens

Hi @TimGeyssens . I'm not sure either

marciogoularte avatar Nov 24 '21 16:11 marciogoularte

yeah need to look into it, doesn't seem to do the correct stuff...

TimGeyssens avatar Dec 15 '21 21:12 TimGeyssens

I'm trying it out now. I had the issue:

System.InvalidOperationException: Unable to resolve service for type 'UIOMatic.IUIOMaticHelper' while attempting to activate 'UIOMatic.Web.Controllers.UIOMaticTreeController'.

Adding:

services.AddSingleton<IUIOMaticHelper, UIOMaticHelper>();

In my Startup.ConfigureServices method seemed to help.

Update

I'm trying to upgrade to Umbraco v9 but the site was having a strange issue:

No controller/action found by name Render.Index

My project structure is like:

  • Web
    • Depends on Nibble.Umbraco.UIOMatic
  • Core
    • Depends on Nibble.Umbraco.UIOMatic.Core

Seems that Nibble.Umbraco.UIOMatic.Core depends on Umbraco.Cms.Core ≥ 9.0.0 and Umbraco.Cms ≥ 9.0.0, but I doubt it should be using Umbraco.Cms?

I don't want my Core project to have a sub-dependency of Umbraco.Cms as it adds files like ~/umbraco/UmbracoWebsite/NoNodes.cshtml which I think messes with the build.

My site doesn't really need UIOMatic that much so I'm disabling it now. Not looking for a solution anytime soon, thought I'd just add my thoughts.

harvzor avatar Jan 02 '22 20:01 harvzor

thanks @Harvzor , yeah the nuget package needs some work, thanks for letting me know

TimGeyssens avatar Jan 03 '22 08:01 TimGeyssens

What do i have to do to get this working? Registered .AddUIOMatic() in startup but now i get a null reference exception in /umbraco/ServerVariables: "NullReferenceException: Object reference not set to an instance of an object. UIOMatic.Web.UIOMaticServerVariablesHandler.Handle(ServerVariablesParsingNotification notification)" in backoffice and a bunch of errors from angular.

davidsandstrom avatar May 17 '22 07:05 davidsandstrom

@marciogoularte any pointers?

TimGeyssens avatar Jul 05 '22 08:07 TimGeyssens

What do i have to do to get this working? Registered .AddUIOMatic() in startup but now i get a null reference exception in /umbraco/ServerVariables: "NullReferenceException: Object reference not set to an instance of an object. UIOMatic.Web.UIOMaticServerVariablesHandler.Handle(ServerVariablesParsingNotification notification)" in backoffice and a bunch of errors from angular.

That will be missing config elements in appsettings.json - I commented in more detail in https://github.com/TimGeyssens/UIOMatic/issues/197

dataworking avatar Aug 03 '22 23:08 dataworking

version 4.1.0 adds default config

TimGeyssens avatar Sep 07 '22 15:09 TimGeyssens