Tim Daubenschütz issues

Results 226 issues of


                                            Tim Daubenschütz

change `string uri` to `bytes metadata` in give and take function

- https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/149?u=timdaub - https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/150?u=timdaub - https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/151?u=timdaub - https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/152?u=timdaub /cc @frangio

Is it a problem that `testTakeEOA` and `testGiveEOA` produce the same validation signature?

see: - https://github.com/rugpullindex/ERC4973/blob/bb471bcdc6a5871731566debeab97766e4423bbb/src/ERC4973.t.sol#L407 - https://github.com/rugpullindex/ERC4973/blob/bb471bcdc6a5871731566debeab97766e4423bbb/src/ERC4973.t.sol#L480

question

implement eip-5267 for structured eip-712 domain retrieval

https://eips.ethereum.org/EIPS/eip-5267

consider making _mint private so that it is absolutely not used by implementers

- OZ's EIP-20 and EIP-721 encourage library users to override the internal mint functions and extend them for their purposes. - But overriding mint in eip-4973 can break the entire...

Now that function burn was renamed to function unequip we can't distinguish between someone disassociating themselves or "trashing" an item and someone unequipping it

consider foundry recommendation on how to test EIP-712

- https://book.getfoundry.sh/tutorials/testing-eip712.html

set up a linter that checks if files all use two spaces

add consensual burning sbts eip

we cannot parse transaction input data

- catalog v2 stores the creator's address in an ethereum transaction's call data: https://github.com/neume-network/strategies/issues/324#issuecomment-1285501936 (sometimes also called "input data") - surprisingly, there isn't a good way to parse call data...

Use weiroll to batch process multiple eth_call requests in a single RPC call

- [email protected] adds weiroll support - technically, this means that if we had an eth_call to weiroll call converter, then we could take some of the eth_calls in the queue,...