Tim Daubenschütz
Tim Daubenschütz
ah great find. The reason for using account abstraction is that I wasn't aware of prank. Feel free to send a PR
related: https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/124?u=timdaub
It also displays "0" for ERC721 tokens that don't implement the enumerable extension. But yeah, I'd be open to adding totalSupply to the EIP interface. Ur welcome to send a...
One question I have regarding the problem this is solving: - Would this allow separating the tokenURI in e.g. baseURI and extension similar to how it was done with OpenZeppelin...
> * [ ] please update the interface identifier everywhere too: https://github.com/rugpullindex/ERC4973/pull/52/files#diff-d6d069dfcb878b5b981b7d3dd18dce17746639eea3f30d1902f4a4cd46364f84R6 > * [x] Make foundry tests pass I‘m happy to merge it when these points are completed
thx I‘ll take over getting this into the main branch. thanks again
Rebased and merged. Thank you again @frangio
@frangio shall we implement this in eip4973?
related: https://github.com/ethers-io/ethers.js/issues/3262
I think this isn't the case anymore with us fixing https://github.com/advisories/GHSA-4h98-2769-gh6h