html-to-vdom
html-to-vdom copied to clipboard
TimBeyer
SVG Support
Incorporates https://github.com/TimBeyer/html-to-vdom/pull/22
Added a few extra tests for more code coverage
Hey, thanks a lot for the extended PR.
What I'm really missing to finally merge the SVG support is to follow the more modular structure I introduced in https://github.com/TimBeyer/html-to-vdom/pull/21
Currently the SVG handling is kind of a regression code-wise, at the same time leaving the modules lying around as orphaned code.
Once that is taken care of I'll gladly merge this.
Hey @spattersongt, sorry I never got back to you. To be honest, I just never noticed you pushed some additional commits.
I promise I'll review this in the coming days. Your contribution is much appreciated :)
This would be awesome to have, is there anything I could do to help with it ?
Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec55cf4c60d18938e80fa724bb19d7c31fa on spattersongt:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.
Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec55cf4c60d18938e80fa724bb19d7c31fa on spattersongt:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.
Something I'm working on depends on inline SVG support, and I'd love to use this library. What are the next steps on this PR?
👍 Chiming in along with the other commenters, is there any plans to merge this? Or if there's still specific issues with the PR, is there anything I can do to help?
For the meantime I'm going to use the fork from @shaunpatterson
Coverage remained the same at 100.0% when pulling e65af81ee26dd619caf30c5a14512d0b91cf359e on shaunpatterson:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.