grunt-aws-lambda icon indicating copy to clipboard operation
grunt-aws-lambda copied to clipboard

replace slash with hyphen in archive name for scoped packages

Open o-farooq opened this issue 9 years ago • 2 comments

When packaging a scoped package, following error is displayed because of the '/' in package name. scoped packages have naming convention @somescope/somepackagename . fixed by replacing '/' with '-'

Running "lambda_package:default" (lambda_package) task Fatal error: ENOENT: no such file or directory, open 'C:\Users****\AppData\Local\Temp\1457437821029.6345@az\bit-api_1-0-0_2016-2-9-0-50-21.zip'

o-farooq avatar Mar 08 '16 11:03 o-farooq

Thanks for the pull request!

Would you mind adding some unit tests? Also, would this affect behaviour for existing users who might have hard-coded the output package name somewhere? Do you think it might be better to have an option to enable or disable it?

Tim-B avatar Mar 20 '16 18:03 Tim-B

Thanks for your fix ! It really helped me! can't wait to see that on master

joInMontreal avatar Oct 23 '16 02:10 joInMontreal