Tillerinobot icon indicating copy to clipboard operation
Tillerinobot copied to clipboard

!now command doesn't use combo or miss count

Open jonstvns opened this issue 7 years ago • 3 comments

The !now command doesn't appear to use your last play's combo or miss count, so it returns the wrong pp value. Is this something that is able to be fixed/improved?

The last play using !now: image

The same play using !acc with all of the parameters filled in: image

jonstvns avatar Feb 12 '18 09:02 jonstvns

The idea of the !now command is not to see how much your pp your last play gave, but to see what had happened if you got a FC on the last play (includes no misses). It's more of a how-much-pp-did-I-just-miss-out-on-command.

Tillerino avatar Feb 13 '18 09:02 Tillerino

I guess that makes sense.

Would it be much trouble to also have a command that includes combo and misses from the last play?

jonstvns avatar Feb 15 '18 16:02 jonstvns

that would be super easy to make, if there is demand for it, sure.

@Tillerino suggestion on command naming? some optional argument kinda thing to !now or something completely different, like !last or something, idk?

omkelderman avatar Feb 16 '18 13:02 omkelderman