TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Add mutex to guard context tags

Open ypatia opened this issue 1 year ago • 2 comments

For C-API tracing, we ended up using tags instead of config to store trace context for Jaeger traces, because we needed that to be mutable (to be able to update the tag when we'd like traces to nest). However, tags were not protected via some locking mechanism, so this PR is adding a mutex to guard tags_ variable.


TYPE: NO_HISTORY DESC: Add mutex to guard context tags

ypatia avatar May 29 '24 13:05 ypatia

This facility has been moved entirely to class RestClient in #4994. I am currently working out the build problems there (the C++ code itself is done).

In addition, mutex protection needs to happen on read in addition to write. That's not currently possible with the way this facility is implemented with StorageManager in the middle.

Thank you @eric-hughes-tiledb for the heads up on those parallel changes. I checked your PR and added a comment.

ypatia avatar May 30 '24 07:05 ypatia

This will get closed once #4994 gets merged.

KiterLuc avatar Jun 11 '24 16:06 KiterLuc

After the REST refactor in #4994 this might be irrelevant or needs to be reimplemented. Closing for now.

KiterLuc avatar Jul 18 '24 10:07 KiterLuc